-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: Add scheduledAt field to tasks to allow proper time-to-ready metric #1667
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
65e16e4
to
b85c4fb
Compare
Codecov Report
@@ Coverage Diff @@
## master #1667 +/- ##
===================================================
+ Coverage 53.13268% 53.16973% +0.03705%
===================================================
Files 74 74
Lines 4884 4890 +6
Branches 941 944 +3
===================================================
+ Hits 2595 2600 +5
Misses 1961 1961
- Partials 328 329 +1
Continue to review full report in Codecov by Sentry.
|
What does this pull request do? Explain your changes. (required)
This adds a
scheduledAt
field to tasks so we can tell how long an assetactually took to upload then how long it actually took to be processed.
upload time = task->scheduledAt - task->createdAt
time to ready = task->status->updatedAt - task->scheduledAt
On the way, also added an
uploading
phase to assets cause we need that for too long already.Specific updates (required)
scheduledAt
field to tasks and udpate them from scheduleruploading
phase to assets and update it from controllerHow did you test each of these updates (required)
in
yarn test
s we trustDoes this pull request close any open issues?
Implements API-31
Checklist