Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MP4 in Transcode API #1673

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Mar 30, 2023

No description provided.

@leszko leszko requested a review from a team as a code owner March 30, 2023 08:31
@vercel
Copy link

vercel bot commented Mar 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Mar 30, 2023 at 8:31AM (UTC)

@leszko leszko requested review from victorges and gioelecerati and removed request for victorges March 30, 2023 08:31
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! only a question comment

@@ -1784,6 +1794,15 @@ components:
type: string
description: Path for the HLS output
example: /samplevideo/hls
mp4:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between the 2 outputs fields you added this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One is for HLS output (so if you specify it, you'll get the HLS output video), one is for MP4 (so if you specify it, you'll get your video transcoded as mp4 files).

But, their structure is the same.

@leszko leszko merged commit c924809 into master Apr 3, 2023
@leszko leszko deleted the rafal/add-mp4-to-transcode-api branch April 3, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants