Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling on stream suspension #1676

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Conversation

victorges
Copy link
Member

What does this pull request do? Explain your changes. (required)

This was made as I was trying to fix the stream suspension API. In the end,
no code changes are necessary and only the mist password was configured wrong.

This will make the errors a little clearer though.

Specific updates (required)

  • Fix the auth challenge handling on the mist API to avoid a stack overflow on wrong password
  • Fix the suspension dialog on the dashboard to not hang on screen forever on errors

How did you test each of these updates (required)
Sent to staging and tested the error flows.

Does this pull request close any open issues?
Related to API-38

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@victorges victorges requested review from a team as code owners March 31, 2023 19:54
@vercel
Copy link

vercel bot commented Mar 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Mar 31, 2023 at 7:54PM (UTC)

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #1676 (6a41e22) into master (2d0af2f) will not change coverage.
The diff coverage is 0.00000%.

Impacted file tree graph

@@              Coverage Diff              @@
##              master       #1676   +/-   ##
=============================================
  Coverage   52.98203%   52.98203%           
=============================================
  Files             74          74           
  Lines           4896        4896           
  Branches         954         970   +16     
=============================================
  Hits            2594        2594           
  Misses          1969        1969           
  Partials         333         333           
Impacted Files Coverage Δ
packages/api/src/controllers/mist-api.ts 0.00000% <0.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d0af2f...6a41e22. Read the comment docs.

Impacted Files Coverage Δ
packages/api/src/controllers/mist-api.ts 0.00000% <0.00000%> (ø)

Copy link
Member

@gioelecerati gioelecerati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorges victorges merged commit 3bc6917 into master Apr 4, 2023
@victorges victorges deleted the vg/fix/stream-suspend branch April 4, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants