Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www: Fix webhooks UI for access control #1677

Merged
merged 4 commits into from
Mar 31, 2023
Merged

Conversation

victorges
Copy link
Member

What does this pull request do? Explain your changes. (required)

Started from just adding the webhook ID on the details page (since it's required
in the new access control flow) and ended up doing some other improvements.

Specific updates (required)

  • Add webhook ID field on details page so it can be easily copied
  • Show playback.accessControl event first on event list
  • Other "text" nits (create button text, webhook details title as name instead of url)

How did you test each of these updates (required)
Create a webhook, check details, copy the ID, etc

Does this pull request close any open issues?
Related to access control but we had no ticket for this.

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@victorges victorges requested a review from a team as a code owner March 31, 2023 22:42
@vercel
Copy link

vercel bot commented Mar 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 10:42PM (UTC)

Copy link
Member

@0xcadams 0xcadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Screenshot 2023-03-31 at 3 44 01 PM

@victorges victorges merged commit 942156d into master Mar 31, 2023
@victorges victorges deleted the vg/feat/webhook-id-disaply branch March 31, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants