Implement Recording V2

[emranemran]

What does this pull request do? Explain your changes. (required)

Change Recording from using go-livepeer (aka. Recording V1) to using Mist (aka Recording V2).

Related design doc: Livestream Recordings Refactor

Specific updates (required)

• Add env variable LP_API_RECORDING_SOURCE_URL to define the public bucket URL where Mist stores recordings
• Add recordingSessionId field to the session DB object and fill it with sessionID (uuid) passed from Mist
• Use Catalyst VOD transcoding to output the recording asset
• Resolve recording URL (both HLS and MP4) from asset instead of statically defined source.mp4 and index.m3u8
• Change UI to read MP4 from mp4Url (rather than converting HLS URL)

Additional comments

• We now need to make 2 DB calls to fetch each HLS/MP4 recording path; this may have some performance implications, but I suggest to refactor/improve it in a separate PR
• There should be also some additional changes to clean up the Recording V1 code, but I think we should do it after the deployment to prod (Added ticket for it here)

TODO before merging this PR

• Clean up code & unit tests
• Fix issue with session re-usage
• Fix issue in Mist to storage Manifest file in the correct directory
• HLS Manifest input in Catalyst

How did you test each of these updates (required)

Does this pull request close any open issues?

Screenshots (optional)

Checklist

• I have read the CONTRIBUTING document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.

[linear]

VID-136 mapic: include RecordingSessionID in PUT /setactive call

In the PUSH_REWRITE trigger handler in mapic, we need to call PUT /stream/:id/:recordingsessionid/setactive to pass alont the recording session id to Studio.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
livepeer-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 2, 2023 2:50pm

[leszko]

@victorges I think I addressed all parts related to the 1-N change. Btw. thanks for the hints about the code parts.

I think the most difficult is this isActive to avoid asset duplication for the given session. I removed all related code and used session.id as asset.id. It may be considered a hack, but on the other hand, I think this solves the issue of duplicates in the right way. I think the previous solution was actually prone to race conditions. If we don't want the asset and session to share the id, the other option is to create a new field like asset.recordingSessionId and make it unique. In theory, we could make asset.source.sessionId as unique, but I guess we already have some duplicated entries in prod. Let me know your thoughts.

Other than that, I think it works fine.

[leszko]

@victorges Please look into this PR again.

[victorges]

LGTM!! 🎉

tho the tests are still failing

[leszko]

Addressed all the comments.