Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Default to HTTPS protocol for frontend links #1708

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

victorges
Copy link
Member

What does this pull request do? Explain your changes. (required)

We were creating http URLs that break on Brave. Don't know when x-forwarded-proto
stopped being set but I think the default should be HTTP anyway.

Specific updates (required)
http->https

How did you test each of these updates (required)
Create an account and make sure email verification is HTTPS

Does this pull request close any open issues?
DX-184

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@victorges victorges requested a review from a team as a code owner April 27, 2023 21:12
@vercel
Copy link

vercel bot commented Apr 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview Apr 27, 2023 9:12pm

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #1708 (6482f8c) into master (8b49763) will not change coverage.
The diff coverage is 100.00000%.

Impacted file tree graph

@@              Coverage Diff              @@
##              master       #1708   +/-   ##
=============================================
  Coverage   52.78002%   52.78002%           
=============================================
  Files             75          75           
  Lines           4964        4964           
  Branches         988         988           
=============================================
  Hits            2620        2620           
  Misses          2007        2007           
  Partials         337         337           
Impacted Files Coverage Δ
packages/api/src/controllers/user.ts 42.60355% <100.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b49763...6482f8c. Read the comment docs.

Impacted Files Coverage Δ
packages/api/src/controllers/user.ts 42.60355% <100.00000%> (ø)

@adamsoffer adamsoffer self-requested a review April 28, 2023 16:47
Copy link
Member

@adamsoffer adamsoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorges victorges merged commit 4522dde into master Apr 28, 2023
11 checks passed
@victorges victorges deleted the vg/fix/email-verification-proto branch April 28, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants