api/auth: Add capacity to authorize via playback ID #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #1714 +/- ##
===================================================
+ Coverage 53.61029% 53.86283% +0.25254%
===================================================
Files 75 75
Lines 5055 5074 +19
Branches 1008 1017 +9
===================================================
+ Hits 2710 2733 +23
+ Misses 2001 1999 -2
+ Partials 344 342 -2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
victorges
force-pushed
the
vg/feat/viewership-auth
branch
from
67cd44b
to
54c8bc4
Compare
victorges
changed the title
leszko
approved these changes
May 5, 2023
| @@ -16,30 +17,51 @@ type UserOwnedObj = { id: string; deleted?: boolean; userId?: string }; | |||
| async function checkUserOwned( | |||
| req: Request, | |||
| headerName: string, | |||
| table: Table<UserOwnedObj> | |||
| getter: (id: string) => Promise<UserOwnedObj> | |||
This will help creating an API to retrieve any kind of resource by playback ID. Coming next.
Oh JavaScript...
victorges
force-pushed
the
vg/feat/viewership-auth
branch
from
448577a
to
8f19629
Compare
victorges
force-pushed
the
vg/feat/viewership-auth
branch
from
c6133bf
to
b06dd40
Compare
This reverts commit b06dd40.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This is to increment the
/api/authAPI, used by external services that need tobuild on top of the API authorization, to also support authorizing access to a
given playback ID. This playback ID can not only be the canonical playback ID of
assets/streams, but can also be the "aliased" IDs like a dStorage ID.
This will be used in the viewership v2 API when it is accessed with a playback ID filter.
Specific updates (required)
x-livepeer-playback-idheader support to auth APIgetResourceByPlaybackIdat some point)How did you test each of these updates (required)
yarn testDoes this pull request close any open issues?
Implements API-50
Checklist