api/playback: Stop returning assets from other users on playback info #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
victorges
force-pushed
the
vg/feat/viewership-auth
branch
from
448577a
to
8f19629
Compare
victorges
force-pushed
the
vg/fix/cross-playback-info
branch
from
8eceb1f
to
29815fa
Compare
victorges
force-pushed
the
vg/fix/cross-playback-info
branch
from
29815fa
to
79ec27f
Compare
victorges
force-pushed
the
vg/feat/viewership-auth
branch
from
c6133bf
to
b06dd40
Compare
victorges
force-pushed
the
vg/fix/cross-playback-info
branch
from
79ec27f
to
4d14f0e
Compare
victorges
force-pushed
the
vg/fix/cross-playback-info
branch
from
4d14f0e
to
c8c0baf
Compare
victorges
force-pushed
the
vg/fix/cross-playback-info
branch
from
c8c0baf
to
e27c834
Compare
gioelecerati
reviewed
May 8, 2023
| @@ -184,7 +213,10 @@ app.get("/:id", async (req, res) => { | |||
| const ingest = ingests[0].base; | |||
|
|
|||
| let { id } = req.params; | |||
| const info = await getPlaybackInfo(req, ingest, id); | |||
| const isEmbeddablePlayer = embeddablePlayerOrigin.test( | |||
| req.headers["origin"] ?? "" | |||
There was a problem hiding this comment.
This could be spoofed on applications outside of the browser to do a cross user query on CIDs, but we probably don't mind
There was a problem hiding this comment.
Yeah it's more about billing the right user than protecting any kind of sensitive info.
victorges
force-pushed
the
vg/fix/cross-playback-info
branch
from
e27c834
to
532f526
Compare
Codecov Report
@@ Coverage Diff @@
## vg/feat/viewership-auth #1717 +/- ##
=================================================================
+ Coverage 53.86283% 53.89470% +0.03187%
=================================================================
Files 75 75
Lines 5074 5071 -3
Branches 1017 1019 +2
=================================================================
Hits 2733 2733
+ Misses 1999 1998 -1
+ Partials 342 340 -2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
victorges
force-pushed
the
vg/fix/cross-playback-info
branch
from
532f526
to
942682d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This is to stop returning assets from other users on the playback info endpoint.
This is a breaking change so we're doing it with a cut-off date logic instead
of breaking existing assets that might be used cross-user today.
Specific updates (required)
How did you test each of these updates (required)
yarn testwith the new testsDoes this pull request close any open issues?
Fixes API-45
Checklist