api/schema: Fix API schema after API reference refactor #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
victorges
force-pushed
the
vg/fix/api-schema
branch
from
229eb38
to
7ce428e
Compare
victorges
changed the title
Also deleted an even older test.json file lol
Will be helpful for debugging
Codecov Report
@@ Coverage Diff @@
## master #1720 +/- ##
=============================================
Coverage 53.61029% 53.61029%
=============================================
Files 75 75
Lines 5055 5055
Branches 1008 1008
=============================================
Hits 2710 2710
Misses 2001 2001
Partials 344 344 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
gioelecerati
approved these changes
May 8, 2023
| @@ -1,6 +1,6 @@ | |||
| import Ajv from "ajv"; | |||
| import pack from "ajv-pack"; | |||
| import { safeLoad as parseYaml } from "js-yaml"; | |||
| import { safeLoad as parseYaml, safeDump as serializeYaml } from "js-yaml"; | |||
There was a problem hiding this comment.
Is safeDump supposed to be imported?
There was a problem hiding this comment.
Yeah it's used to write the merged yaml now!
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
On the API reference refactor we created new schema files but forgot to delete
the old one, so it was able to merge cleanly even though it had conflicts with master.
This was caused by a couple other conflicting changes to the schema. Specifically:
Specific updates (required)
How did you test each of these updates (required)
yarn testDoes this pull request close any open issues?
No.
Checklist