Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: new webhook page #2009

Merged
merged 15 commits into from
Feb 15, 2024
Merged

ui: new webhook page #2009

merged 15 commits into from
Feb 15, 2024

Conversation

suhailkakar
Copy link
Member

@suhailkakar suhailkakar commented Jan 5, 2024

What does this pull request do? Explain your changes. (required)

  • updated the new webhook ui pages

Specific updates (required)

  • update the tables of the webhook list
  • update the webhook page

How did you test each of these updates (required)

N/A

Does this pull request close any open issues?

Screenshots (optional)

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@suhailkakar suhailkakar requested a review from a team as a code owner January 5, 2024 14:24
Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 1 unresolved
✅ 3 resolved
Feb 15, 2024 4:04pm

Copy link
Member

@adamsoffer adamsoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left one last minor comment. Good to merge today after that. Can follow up with remaining filters (date and resource) in a follow up PR.

border: activeFilter === filter ? "2px solid" : "1px solid",
borderColor: activeFilter === filter ? "$blue11" : "$neutral8",
width: "20%",
borderRadius: "$3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a cursor: default to this component otherwise the hover state on the text uses cursor: text

@adamsoffer adamsoffer merged commit cdbd0fe into master Feb 15, 2024
9 of 10 checks passed
@adamsoffer adamsoffer deleted the sk/webhook branch February 15, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants