Add stream config endpoint #2033
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (!stream) { | ||
| stream = await db.stream.get(id); | ||
| } |
There was a problem hiding this comment.
Perhaps by streamKey instead? Catalyst never gets the stream ID AFAIK.
But also, maybe we want to be explicit here by using query-strings instead like /api/stream/config?playbackId=<pid> or /api/stream/config?streamKey=<sk>
Otherwise, I'm concerned we could for example eventually start allowing playback by stream key or stream id, which could leak to accidental leaks of those for example 🤔 (stream ID is also secret, it kinda gives ownership over the resource if the app uses a frontend API key)
ORRR, to keep it simple, we can allow only playback ID for now and think about this later when this evolves for example to replace the API that mapic calls.
| if (!stream) { | ||
| stream = await db.stream.get(id); | ||
| } | ||
| if (!stream) { |
There was a problem hiding this comment.
Need to check stream.deleted and maybe stream.suspended as well
No description provided.