Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Implement MVP of stream pull trigger #2038

Merged
merged 7 commits into from
Feb 2, 2024

Conversation

victorges
Copy link
Member

What does this pull request do? Explain your changes. (required)

This implements the simplest form of triggering a stream to start pulling, by making a
call to the stream playbackUrl after creating the stream.

The main missing feature here would be using the pull.location field to call the Catalyst
instance closest to the pull location. This might be implemented later through a Catalyst
API in catalyst-api instead, so Studio doesn't need to track the state of the serf cluster
to know what nodes are online.

Specific updates (required)

  • Refactored the fetchWithTimeoutAndRedirects function as I was reading it to understand the logic
  • Implemented triggerCatalystPullStart for real with some TODO/comments for context

How did you test each of these updates (required)
yarn test

Does this pull request close any open issues?
Implements ENG-1569

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@victorges victorges requested a review from a team as a code owner February 2, 2024 18:38
Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 7:32pm

No time for testing anymore, but ideally we would.
@emranemran emranemran merged commit 6913261 into master Feb 2, 2024
12 checks passed
@emranemran emranemran deleted the vg/feat/actually-wait-active branch February 2, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants