Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: playback: require auth for playback recordings #2043

Merged
merged 3 commits into from
Feb 20, 2024
Merged

api: playback: require auth for playback recordings #2043

merged 3 commits into from
Feb 20, 2024

Conversation

gioelecerati
Copy link
Member

What does this pull request do? Explain your changes. (required)

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Screenshots (optional)

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@vercel Vercel
Copy link

vercel bot commented Feb 8, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 5:35pm

victorges
victorges approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM anyway but we should avoid fetching the data twice. This API is on the critical path for playback and any millisecond counts!

packages/api/src/controllers/playback.ts Outdated Show resolved Hide resolved
@gioelecerati gioelecerati marked this pull request as ready for review February 20, 2024 17:32
@gioelecerati gioelecerati requested a review from a team as a code owner February 20, 2024 17:32
@gioelecerati gioelecerati merged commit b899c73 into master Feb 20, 2024
10 checks passed
@gioelecerati gioelecerati deleted the gio/api/playback-recordings-auth branch February 20, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorges victorges victorges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gioelecerati @victorges