api: webhook: allow additional headers & payload to be sent in webhooks #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gioelecerati
force-pushed
the
gio/api/customized-webhook-payload
branch
from
1f5c30d
to
31b79c0
Compare
mjh1
approved these changes
Feb 15, 2024
victorges
reviewed
Feb 20, 2024
| } | ||
|
|
||
| if (isTrovoAuth) { | ||
| params.headers["Trovo-Auth-Version"] = "1.1"; |
There was a problem hiding this comment.
This hurts 😆
Let's make sure to migrate these to per-webhook headers configs later, which Trovo can play around however they want. We should avoid hardcoded logic for specific clients.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Allow catalyst to specify two new objects when calling Studio gate
webhookPayloadwebhookHeadersThey will get appended to the JSON payload and the headers respectively when doing a webhook request for access control to an external party
Also added
Trovo-Auth-Version: 1.1as header to any webhook fired for a stream created via thepullapiSpecific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Screenshots (optional)
Checklist