Add a webhook log success field to allow filtering in the UI #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mjh1
force-pushed
the
mh/webhook-success
branch
from
885f7c0
to
6524701
Compare
mjh1
force-pushed
the
mh/webhook-success
branch
from
6524701
to
7def825
Compare
mjh1
changed the title
leszko
approved these changes
Feb 16, 2024
| @@ -26,6 +26,7 @@ const requestsFieldsMap: FieldsMap = { | |||
| userId: `webhook_log.data->>'userId'`, | |||
| event: `webhook_log.data->>'event'`, | |||
| statusCode: `webhook_log.data->'response'->>'status'`, | |||
| success: `webhook_log.data->>'success'`, | |||
There was a problem hiding this comment.
I'm not sure how simple it would be, but you can consider adding unit test for this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Adding a success field to webhook logs so that we can easily filter based on this in the UI.
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Screenshots (optional)
Checklist