api: flag streams as pull created for auth header in webhook #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thomshutt
approved these changes
Feb 19, 2024
victorges
reviewed
Feb 20, 2024
Comment on lines
+475
to
+480
| isPullStream: | ||
| type: boolean | ||
| readOnly: true | ||
| description: >- | ||
| Wether the stream is authenticated by Trovo. If true, any webhook | ||
| policy will include the Trovo Auth header | ||
| Wether the stream is a pull stream. If true, any webhook policy will | ||
| include the Trovo Auth header |
There was a problem hiding this comment.
We can already tell this by the existence of the pull field, so this is redundant. It should also be omitted from API schema not to pollute our public documentation. So you can move this to db-schema or just omit from the schema altogether (tho I guess this would break typescript stuff, unless you start using the stream.pull for it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Screenshots (optional)
Checklist