Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminate the stream if the pull source has been updated #2071

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Feb 22, 2024

What does this pull request do? Explain your changes. (required)

If the stream source has changed we need to terminate the existing stream so that a new stream with the updated source can start up in the backend.

Specific updates (required)

How did you test each of these updates (required)

Tested locally with box environment

Does this pull request close any open issues?

Screenshots (optional)

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@mjh1 mjh1 requested a review from a team as a code owner February 22, 2024 11:52
Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 1:52pm

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjh1 mjh1 merged commit 742f06c into master Feb 22, 2024
13 checks passed
@mjh1 mjh1 deleted the mh/pull-stream-update branch February 22, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants