Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook page #2074

Merged
merged 16 commits into from
Feb 28, 2024
Merged

Webhook page #2074

merged 16 commits into from
Feb 28, 2024

Conversation

suhailkakar
Copy link
Member

@suhailkakar suhailkakar commented Feb 25, 2024

What does this pull request do? Explain your changes. (required)

  • added filters (resource id, events, date)
  • fixed the ui of right panel
  • fixed the response for stream.idle/started
  • update success/failed logic from api response
  • removed console.logs

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Screenshots (optional)

Checklist

  • I have read the CONTRIBUTING document.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have added tests to cover my changes.

@suhailkakar suhailkakar requested a review from a team as a code owner February 25, 2024 08:55
Copy link

vercel bot commented Feb 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 4:20pm

Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @suhailkakar . Added a few comments.

One more thing is that when you click "Resend", then the UI is not refreshed with the new webhook call automatically. Could you check?

@suhailkakar suhailkakar merged commit 7290729 into master Feb 28, 2024
13 checks passed
@suhailkakar suhailkakar deleted the webhook-page branch February 28, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants