stream/helpers: reduce some delays in await functions #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mjh1
approved these changes
Feb 26, 2024
victorges
reviewed
Feb 27, 2024
| @@ -674,7 +674,7 @@ export const triggerCatalystPullStart = | |||
| res.status | |||
| } error=${JSON.stringify(body)}` | |||
| ); | |||
| await sleep(1000); | |||
| await sleep(250); | |||
There was a problem hiding this comment.
I wonder if this could have bigger risks of concurrency issues, given each of these requests might hit a different catalyst instance. Then we could have multiple instances starting a pull at the same time (not sure what errors could happen after that tho). Let's keep this in mind if we notice any issues (this has been deployed to prod earlier today)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.