-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull stream start improvements #2086
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm anyway
@@ -661,12 +661,16 @@ export const triggerCatalystPullStart = | |||
timeout: PULL_START_TIMEOUT, | |||
maxRedirects: 10, | |||
}); | |||
const body = await res.text(); | |||
const isHlsErr = body.includes("#EXT-X-ERROR: Stream open failed"); | |||
const errHeader = res.headers.get("error"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test
if (waitActive === "true") { | ||
stream = await pollWaitStreamActive(req, stream.id); | ||
} | ||
await triggerCatalystPullStart(stream, getHLSPlaybackUrl(ingest, stream)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so in practice we always wait for the stream to start, is that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes if the manifest request has returned then the stream has started and ready for playback
No description provided.