api: asset: delete & restore #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| res.end(); | ||
| }); | ||
|
|
||
| app.patch("/:id/deleted", authorizer({ anyAdmin: true }), async (req, res) => { |
Check failure
Code scanning / CodeQL
Missing rate limiting High
victorges
requested changes
Mar 19, 2024
| let updatedAt = asset.status?.updatedAt; | ||
|
|
||
| if (phase == "ready") { | ||
| // If the asset is ready, we need to schedule deletion |
There was a problem hiding this comment.
I wonder if we want to trigger this for failed assets too. Maybe there are left overs?
| await req.taskScheduler.deleteAsset(asset); | ||
| res.status(204); | ||
| res.end(); | ||
| }); | ||
|
|
||
| app.post("/:id/restore", authorizer({}), async (req, res) => { |
Check failure
Code scanning / CodeQL
Missing rate limiting High
gioelecerati
force-pushed
the
gio/asset/deleting-phase
branch
from
a94e43c
to
48b22fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Screenshots (optional)
Checklist