Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projects: add projects and projectId scoping to assets/api-token cotrollers #2102

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

emranemran
Copy link
Contributor

  • Reverting the reverted PR
  • Added one commit on top to fix the issues with incorrect queries. Previously, records with a missing projectId was being selected. The updated query handles this case correctly.

The previous queries were selecting records where projectId field in the
JSONB data column was missing.
@emranemran emranemran requested a review from a team as a code owner March 13, 2024 14:48
Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 2:49pm

return res.json(output);
});

app.get("/:id", authorizer({}), async (req, res) => {

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
, but is not rate-limited.
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed only the commit after the revert. LGTM

Copy link
Contributor

@mjh1 mjh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat 👍

@emranemran emranemran merged commit b5a6b4d into master Mar 25, 2024
12 of 13 checks passed
@emranemran emranemran deleted the emran/projects-assets-apitoken-redo branch March 25, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants