Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement locking stream pull to avoid multiple catalyst pulling the … #2108

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Implement locking stream pull to avoid multiple catalyst pulling the … #2108

merged 3 commits into from
Mar 25, 2024

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Mar 21, 2024

…same stream

@vercel Vercel
Copy link

vercel bot commented Mar 21, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 9:37am

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 21, 2024
View reviewed changes
packages/api/src/controllers/stream.ts Dismissed Show dismissed Hide dismissed
@leszko leszko mentioned this pull request Mar 21, 2024
Merged
@leszko leszko marked this pull request as ready for review March 21, 2024 15:30
@leszko leszko requested a review from a team as a code owner March 21, 2024 15:30
victorges
victorges approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/api/src/controllers/stream.ts Show resolved Hide resolved
packages/api/src/schema/api-schema.yaml Outdated Show resolved Hide resolved
packages/api/src/controllers/stream.test.ts Outdated Show resolved Hide resolved
@leszko leszko merged commit 55d9116 into master Mar 25, 2024
13 checks passed
@leszko leszko deleted the rafal/stream-pull-mark-node branch March 25, 2024 11:23
emranemran added a commit that referenced this pull request Mar 27, 2024
@emranemran
Revert "Implement locking stream pull to avoid multiple catalyst pull…
6ffc3b2 
…ing the … (#2108)"

This reverts commit 55d9116.
emranemran added a commit that referenced this pull request Mar 27, 2024
@emranemran
Revert "Implement locking stream pull to avoid multiple catalyst pull…
a5d5866 
…ing the … (#2108)" (#2114)

This reverts commit 55d9116.
leszko added a commit that referenced this pull request Mar 27, 2024
@leszko
Revert "Revert "Implement locking stream pull to avoid multiple catal…
1a38a2d 
…yst pulling the … (#2108)" (#2114)"

This reverts commit a5d5866.
@leszko leszko mentioned this pull request Mar 27, 2024
Merged
mjh1 pushed a commit that referenced this pull request Mar 27, 2024
@leszko
Revert "Revert "Implement locking stream pull to avoid multiple catal…
15654c9 
…yst pulling the … (#2108)" (#2114)" (#2115)

This reverts commit a5d5866.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorges victorges victorges approved these changes

@mjh1 mjh1 mjh1 approved these changes

@thomshutt thomshutt Awaiting requested review from thomshutt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leszko @victorges @mjh1