lockPull: check isActive in the transaction and only by different nodes #2117

leszko · 2024-03-28T13:57:44Z

Change isActive inside the DB transaction, because:

As @victorges pointed out in the other PR's comment, better to check it in the transaction
We don't want to check it for the same host, otherwise we may have a race condition between setting isActive and locking pull (we want to lockPull only by other nodes)

vercel · 2024-03-28T13:57:51Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
livepeer-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 29, 2024 6:39am

leszko added 2 commits March 28, 2024 13:50

Move isActive condition to sql

1aa16f8

Check isActive in the transaction and only by different nodes

0fc7858

leszko requested review from victorges and mjh1 March 28, 2024 13:57

leszko requested a review from a team as a code owner March 28, 2024 13:57

vercel bot deployed to Preview March 28, 2024 13:58 View deployment

mjh1 approved these changes Mar 28, 2024

View reviewed changes

Fix SQL Condition

6212f89

vercel bot deployed to Preview March 29, 2024 06:39 View deployment

leszko merged commit d9f20d9 into master Mar 29, 2024
10 checks passed

leszko deleted the rafal/stream-pull-fix-move-is-active branch March 29, 2024 06:53

Provide feedback