Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional logs to /pull #2137

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Add additional logs to /pull #2137

merged 2 commits into from
Apr 18, 2024

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Apr 18, 2024

No description provided.

@leszko leszko requested a review from a team as a code owner April 18, 2024 08:41
@vercel Vercel
Copy link

vercel bot commented Apr 18, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 8:51am

gioelecerati
gioelecerati approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@gioelecerati gioelecerati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am not sure if starting the log line with / is having any impact with our metrics, it's probably better to be a lowercase normal character

@leszko leszko merged commit c0ceb4a into master Apr 18, 2024
10 checks passed
@leszko leszko deleted the rafal/add-logging-to-pull-lock branch April 18, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioelecerati gioelecerati gioelecerati approved these changes

@hjpotter92 hjpotter92 Awaiting requested review from hjpotter92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leszko @gioelecerati