fix stream page ui issues #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adamsoffer
approved these changes
Apr 26, 2024
| @@ -196,8 +194,28 @@ const StreamFilter = ({ onDone, activeFilters }) => { | |||
| } | |||
| }, [activeFilters]); | |||
|
|
|||
| const getDropdownMargin = (filterId) => { | |||
There was a problem hiding this comment.
@suhailkakar we really should not need this switch logic. Dropdown components should automatically align to the parent element. We can't have custom logic depending the width of the dropdown element. That is not sustainable. I'm going to merge this PR but let's remove this logic in a follow up PR and use the component correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Screenshots (optional)
Checklist