api: Log the full pull payload for debugging #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
victorges
force-pushed
the
vg/chore/log-pull-payload
branch
from
011abe0
to
fb4c7ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This is to facilitate debugging of the
/pullAPI behavior by logging the full payload received(after redacting some stuff like pull source and multistream targets etc)
Specific updates (required)
Create a redacted payload to log and log it.
How did you test each of these updates (required)
Non-functional change.
yarn testalready catches if there's anything fatal with the log, given there are tests for the endpoint.Does this pull request close any open issues?
Facilitates debugging issues.
Checklist