api: stream: test profiles for test creator ids #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
victorges
approved these changes
Apr 29, 2024
| @@ -1057,9 +1064,21 @@ app.put( | |||
| }); | |||
| } | |||
|
|
|||
| let profiles = req.config.defaultStreamProfiles; | |||
There was a problem hiding this comment.
Can you name this defaultProfiles (and change L1081 to profiles: defaultProfiles) so this is clearer? Otherwise the request will still override these and that can be misleading.
| logger.info( | ||
| `pull request creatorId=${rawPayload.creatorId} is a test creatorId` | ||
| ); | ||
| profiles = rawPayload.profiles; // TODO: specify here the hardcoded profiles for testing |
There was a problem hiding this comment.
Only merge this after changing this to the actual set of profiles.
victorges
force-pushed
the
gio/stream/test-creator
branch
from
214f525
to
3a70fc0
Compare
emranemran
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Screenshots (optional)
Checklist