Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve api schema #2156

Merged
merged 37 commits into from
May 17, 2024
Merged

refactor: improve api schema #2156

merged 37 commits into from
May 17, 2024

Conversation

suhailkakar
Copy link
Member

@suhailkakar suhailkakar commented Apr 30, 2024 •
edited

What does this pull request do? Explain your changes. (required)

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Screenshots (optional)

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@suhailkakar suhailkakar requested a review from a team as a code owner April 30, 2024 15:35
@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 5:00pm

@suhailkakar suhailkakar requested a review from a team as a code owner April 30, 2024 15:40
victorges
victorges approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved anyway but there are some minor comments.

packages/api/src/schema/api-schema.yaml Outdated Show resolved Hide resolved
packages/api/src/schema/api-schema.yaml Show resolved Hide resolved
packages/api/src/schema/api-schema.yaml Show resolved Hide resolved
packages/api/src/schema/api-schema.yaml Outdated Show resolved Hide resolved
packages/api/src/schema/api-schema.yaml Outdated Show resolved Hide resolved
packages/api/src/schema/api-schema.yaml Outdated Show resolved Hide resolved
packages/api/src/schema/api-schema.yaml Outdated Show resolved Hide resolved
packages/api/src/schema/api-schema.yaml Show resolved Hide resolved
packages/api/src/schema/db-schema.yaml Outdated Show resolved Hide resolved
packages/www/pages/app/stream/[id].tsx Outdated Show resolved Hide resolved
victorges
victorges approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was already approved but just confirming, LGTM

@0xcadams 0xcadams mentioned this pull request May 14, 2024
Closed
victorges
victorges approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes since last time. LGTM!

packages/api/src/schema/api-schema.yaml Outdated Show resolved Hide resolved
packages/api/src/schema/api-schema.yaml Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems May 16, 2024
View reviewed changes
packages/api/src/controllers/asset.ts Dismissed Show dismissed Hide dismissed
@victorges victorges merged commit e8a29df into master May 17, 2024
8 checks passed
@victorges victorges deleted the sk/schema-fixes branch May 17, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorges victorges victorges approved these changes

@0xcadams 0xcadams 0xcadams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@suhailkakar @victorges @0xcadams