api,www: Create failed state for recordings
#2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
victorges
changed the title
failed state for recordings
Showing none is just misleading, let's show that only for stale streams
victorges
force-pushed
the
vg/feat/recording-failed-state
branch
from
482e551
to
1716f07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This is just to make a small improvement on the recordingStatus field of streams/sessions.
Previously we had a
nonestate which was only set when we tried to create the recording butthe processing failed. This is pretty misleading as it looks like we never even tried creating one.
So I created a new
failedstate to be set on that case, and am settingnoneonly when weactually won't generate a recording, which is the case for stale sessions (exists today, will stop
happening with #2013).
Specific updates (required)
failedstatus and set it when processing failedHow did you test each of these updates (required)
Simple hotfix,
yarn testguarantees it's not breaking anything.Does this pull request close any open issues?
No.
Checklist