api/cannon: Stop retrying invalid webhooks forever #2167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Turns out there were never any suspended users sending webhooks. Only webhooks
that never got acked from the queue after they got suspended.
When we got an invalid webhook for a deleted or suspended user or stream,
we threw an error from the fucntion that processes the events. Problem was the
caller of that function was retrying on any generic errors.
Made them throw an explicit
UnprocessableEntityError
instead so we dropthe messages accordingly.
Specific updates (required)
UnprocessableEntityError
from main process funcack
messages from themrecording.waiting
events, we can just rethrow nowHow did you test each of these updates (required)
yarn test
Does this pull request close any open issues?
Not sure, we talked about it tho and the webhook queue is never empty.
Checklist