Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Fix double index creation with separate jobs DB pool #2170

Merged
merged 3 commits into from
May 7, 2024

Conversation

victorges
Copy link
Member

What does this pull request do? Explain your changes. (required)

This disables the table/index creation on the separate DB pool used for bg jobs.

It also allows disabling index creation completely, so we can quickly do it on regions
that may be having issues. We won't need to enable that for now though.

Specific updates (required)

  • Disable index creation for jobs DB pool
  • Allow disabling index creation from CLI for all DB clients

How did you test each of these updates (required)
yarn test. also ran API and check each index is created only once

Does this pull request close any open issues?
https://discord.com/channels/423160867534929930/1237342810508623913/1237342812903702538

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@victorges victorges requested a review from a team as a code owner May 7, 2024 11:53
Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 11:56am

@victorges victorges merged commit 9ffcbf5 into master May 7, 2024
8 checks passed
@victorges victorges deleted the vg/fix/double-index-creation branch May 7, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants