Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Allow isMobile to be specified as an int (0 or 1... or 2!) #2172

Merged
merged 2 commits into from
May 9, 2024

Conversation

victorges
Copy link
Member

What does this pull request do? Explain your changes. (required)

Design partner is sending it as an integer for some reason.

Specific updates (required)

  • Add integer type to schema
  • fix type hint on helper to fix profiles

How did you test each of these updates (required)
TypeScript, if it compiles it works lol

Does this pull request close any open issues?
https://discord.com/channels/423160867534929930/1161745351275982848/1237658648327618600

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@victorges victorges requested a review from a team as a code owner May 8, 2024 14:56
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 3:16pm

@victorges victorges changed the title api: Allow isMobile to be specified as an int (0 or 1) api: Allow isMobile to be specified as an int (0 or 1... or 2!) May 8, 2024
Copy link
Member

@gioelecerati gioelecerati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will update the go api client, which is not merged yet as we never did the catalyst-api side, but worth it keep it in line at least in the pr, wdyt?

@victorges victorges merged commit ba56dd4 into master May 9, 2024
8 checks passed
@victorges victorges deleted the vg/chore/is-mobile-as-int branch May 9, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants