Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www/mint-nft: Use Video NFT SDK instead of ethers! #978

Merged
merged 18 commits into from
Apr 8, 2022

Conversation

victorges
Copy link
Member

@victorges victorges commented Mar 23, 2022

What does this pull request do? Explain your changes. (required)

livepeer/video-nft#1

This is to POC the use of the Video NFT SDK with our own page for minting NFTs.

Still pending actually doing the file upload from the frontend page as well, to test
all the code in the SDK that was previously done by the CLI.

Specific updates (required)

  • Replace ethers with @livepeer/video-nft
  • ...

-

  • How did you test each of these updates (required)
    Access /mint-nft and mint some stuff

https://livepeer-com-git-vg-featvideo-nft-sdk-use-livepeer.vercel.app/mint-nft

Does this pull request close any open issues?
Related to #929 but more stuff will be necessary (like docs).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@vercel
Copy link

vercel bot commented Mar 23, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/livepeer/livepeer-com/E4cGYap5QhsFePTiMH4Xy6veByCS
✅ Preview: https://livepeer-com-git-vg-featvideo-nft-sdk-use-livepeer.vercel.app

@figintern
Copy link
Contributor

figintern commented Mar 25, 2022

Cool stuff! Tried it out on the preview branch https://livepeer-com-git-vg-featvideo-nft-sdk-use-livepeer.vercel.app/mint-nft - the Polygon Testnet/Mainnet switching buttons are not working for me, but work for me on the current livepeer.com deployment (they open up a prompt in my metamask)

image

Not sure if this is because app is not running off the livepeer.com domain and there needs to be some whitelisting wired up - or the functionality is broken

image

Not seeing anything in the console logs when clicking these buttons on the preview branch URL either

@victorges
Copy link
Member Author

Thanks @tqian1 ! Just fixed the switch network button.

@victorges victorges merged commit 95a70b7 into master Apr 8, 2022
@victorges victorges deleted the vg/feat/video-nft-sdk-use branch April 8, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants