task/runner: Handle extra import request errs when humanizing #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #104 +/- ##
=================================================
- Coverage 5.45262% 5.38421% -0.06841%
=================================================
Files 14 14
Lines 1889 1913 +24
=================================================
Hits 103 103
- Misses 1777 1801 +24
Partials 9 9
Continue to review full report at Codecov.
|
thomshutt
reviewed
Dec 14, 2022
thomshutt
approved these changes
Dec 14, 2022
victorges
reviewed
Dec 19, 2022
| @@ -475,9 +475,19 @@ func errorInfo(err error) *data.ErrorInfo { | |||
| func humanizeCatalystError(err error) error { | |||
| errMsg := strings.ToLower(err.Error()) | |||
|
|
|||
| fileNotAccessibleErrs := []string{ | |||
| "504 Gateway Timeout", | |||
There was a problem hiding this comment.
This needs to be lower case as well
| // General errors | ||
| if strings.Contains(errMsg, "import request") && strings.Contains(errMsg, "504 Gateway Timeout") { | ||
| return errors.New("file could not be imported from URL because it was not accessible") | ||
| // TODO(yondonfu): This string matching is ugly and we should come up with a better less error-prone way to |
There was a problem hiding this comment.
Agreed. We should probably work with error codes like mediaconvert does (but may always have some string parsing fallback anyway, just hopefully won't be the main logic)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103