Fix 0/0 framerate handling for video tracks when probing #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add testify pkg for testing.
thomshutt
approved these changes
Dec 15, 2022
thomshutt
reviewed
Dec 15, 2022
victorges
reviewed
Dec 19, 2022
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestParseFps(t *testing.T) { |
There was a problem hiding this comment.
Nice! This is a necessary change in this project 🙊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the
parseFps()function would return NaN for an input framerate of 0/0. The NaN value would be set as the value for a track'sFPSfield here. The track is nested in the larger api.AssetSpec struct which is marshalled in saveMetadataFile() which is called during upload task execution after task-runner receives a callback from Catalyst in order to "complement" Catalyst which involves copying the source file into a bucket and also probing the file. The NaN value nested in theapi.AssetSpecstruct results in the following error in the call tosaveMetadataFile():I observed this error for a file containing a mjpeg video track with the avg framerate set to 0/0.