Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task/runner: Fix bug with comparing lowercased errs #113

Merged
merged 1 commit into from
Dec 15, 2022
Merged

task/runner: Fix bug with comparing lowercased errs #113

merged 1 commit into from
Dec 15, 2022

Conversation

yondonfu
Copy link
Member

@yondonfu yondonfu commented Dec 15, 2022 •
edited

Fixes #111 #109

@yondonfu yondonfu requested a review from a team as a code owner December 15, 2022 20:19
@yondonfu yondonfu merged commit 7f46c45 into main Dec 15, 2022
@yondonfu yondonfu deleted the yf/fail-probe-error branch December 15, 2022 20:21
@yondonfu yondonfu mentioned this pull request Dec 15, 2022
Closed
victorges
victorges reviewed Dec 19, 2022
View reviewed changes
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see you fixed those already! Sorry going chronologically over the emails.

I think the ones you added a todo here should be fixed as well. They definitely are not working today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorges victorges victorges left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix error humanization of Failed probe/open MC error
2 participants
@yondonfu @victorges