Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humanize no video codec error #122

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Humanize no video codec error #122

merged 2 commits into from
Jan 6, 2023

Conversation

red-0ne
Copy link
Contributor

@red-0ne red-0ne commented Jan 5, 2023

Translate "no video track found in file" errors to errInvalidVideo

@red-0ne red-0ne requested a review from yondonfu January 5, 2023 16:07
@red-0ne red-0ne requested a review from a team as a code owner January 5, 2023 16:07
@red-0ne red-0ne requested a review from thomshutt January 5, 2023 16:16
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #122 (4e32c53) into main (7438da0) will increase coverage by 0.14621%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                Coverage Diff                @@
##               main       #122         +/-   ##
=================================================
+ Coverage   9.62217%   9.76838%   +0.14621%     
=================================================
  Files            14         14                 
  Lines          1985       1986          +1     
=================================================
+ Hits            191        194          +3     
- Misses         1778       1779          +1     
+ Partials         16         13          -3     
Impacted Files Coverage Δ
task/runner.go 16.54676% <100.00000%> (+0.68138%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7438da0...4e32c53. Read the comment docs.

Impacted Files Coverage Δ
task/runner.go 16.54676% <100.00000%> (+0.68138%) ⬆️

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but might be worth considering a custom error message in this case since it's so clear anyway. The other invalid video errors we have today we'd actually want to eventually parse the wrong thing (like "invalid video codec: x") then makes sense to keep it simple for now.

I'm fine with it as is anyway though. Might be worth checking if that's enough from the product perspective as well.

@red-0ne red-0ne merged commit 8314296 into main Jan 6, 2023
@red-0ne red-0ne deleted the humanize-audio-only-errors branch January 6, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants