Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Humanize MediaConvert inaccessible error and fix test #123

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Humanize MediaConvert inaccessible error and fix test #123

merged 3 commits into from
Jan 6, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Jan 6, 2023

Relates to #119

@mjh1 mjh1 requested a review from a team as a code owner January 6, 2023 11:04
@mjh1 mjh1 requested review from yondonfu and leszko January 6, 2023 11:04
@codecov
Copy link

codecov bot commented Jan 6, 2023 •
edited

Codecov Report

Merging #123 (09ce867) into main (8314296) will increase coverage by 0.13609%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                Coverage Diff                @@
##               main       #123         +/-   ##
=================================================
+ Coverage   9.76838%   9.90447%   +0.13609%     
=================================================
  Files            14         14                 
  Lines          1986       1989          +3     
=================================================
+ Hits            194        197          +3     
  Misses         1779       1779                 
  Partials         13         13
Impacted Files Coverage Δ
task/runner.go 17.14286% <100.00000%> (+0.59610%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8314296...09ce867. Read the comment docs.

Impacted Files Coverage Δ
task/runner.go 17.14286% <100.00000%> (+0.59610%) ⬆️

yondonfu
yondonfu approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after resolving conflicts.

@mjh1 mjh1 merged commit 11e49cd into main Jan 6, 2023
@mjh1 mjh1 deleted the mh/mc-inaccessible-err branch January 6, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yondonfu yondonfu yondonfu approved these changes

@leszko leszko Awaiting requested review from leszko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjh1 @yondonfu