Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through dsotage urls #125

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Pass through dsotage urls #125

merged 2 commits into from
Jan 18, 2023

Conversation

red-0ne
Copy link
Contributor

@red-0ne red-0ne commented Jan 17, 2023

Since IPFS and Arweave urls are now handled by catalyst-api, there is no need to have this logic here and should just pass through the url.

Should close livepeer/studio#1580

@red-0ne red-0ne requested a review from a team as a code owner January 17, 2023 19:59
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #125 (f8c0afa) into main (3047363) will increase coverage by 0.10061%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                Coverage Diff                 @@
##               main        #125         +/-   ##
==================================================
+ Coverage   9.90447%   10.00508%   +0.10061%     
==================================================
  Files            14          14                 
  Lines          1989        1969         -20     
==================================================
  Hits            197         197                 
+ Misses         1779        1759         -20     
  Partials         13          13                 
Impacted Files Coverage Δ
task/upload.go 0.00000% <0.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3047363...f8c0afa. Read the comment docs.

Impacted Files Coverage Δ
task/upload.go 0.00000% <0.00000%> (ø)

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nits

task/upload.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
@thomshutt
Copy link
Contributor

Once this is tested and deployed, is there potentially task-runner config we can clean up (IPFS gateway list etc.) @victorges or is it still used elsewhere?

@red-0ne red-0ne merged commit 642e38b into main Jan 18, 2023
@red-0ne red-0ne deleted the passthrough-dstorage-urls branch January 18, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass through ipfs:// URLs to Catalyst API
3 participants