Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

humanize no pictures decoded error #128

Merged
merged 1 commit into from
Jan 25, 2023
Merged

humanize no pictures decoded error #128

merged 1 commit into from
Jan 25, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Jan 23, 2023

No description provided.

@mjh1 mjh1 requested a review from a team as a code owner January 23, 2023 14:07
@mjh1 mjh1 requested a review from victorges January 23, 2023 14:07
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #128 (ae0e788) into main (51558d7) will increase coverage by 0.04566%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #128         +/-   ##
===================================================
+ Coverage   10.00000%   10.04566%   +0.04566%     
===================================================
  Files             14          14                 
  Lines           1970        1971          +1     
===================================================
+ Hits             197         198          +1     
  Misses          1760        1760                 
  Partials          13          13                 
Impacted Files Coverage Δ
task/runner.go 17.33967% <100.00000%> (+0.19681%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51558d7...ae0e788. Read the comment docs.

Impacted Files Coverage Δ
task/runner.go 17.33967% <100.00000%> (+0.19681%) ⬆️

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

For the future: At some point we should start handling mediaconvert error codes somehow as well instead of relying on error messages.

Perhaps we should support returning human errors directly from catalyst somehow, then we can treat all these errors with more accuracy over there

@mjh1 mjh1 merged commit ce561e5 into main Jan 25, 2023
@mjh1 mjh1 deleted the mh/humanize branch January 25, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants