Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task-runner: add mp4 output in catalyst request & callback #132

Merged
merged 31 commits into from
Feb 16, 2023

Conversation

gioelecerati
Copy link
Member

@gioelecerati gioelecerati commented Feb 1, 2023

@gioelecerati gioelecerati requested a review from a team as a code owner February 1, 2023 14:06
@gioelecerati gioelecerati marked this pull request as draft February 1, 2023 14:06
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #132 (c3e0176) into main (af4b3e0) will decrease coverage by 1.59941%.
The diff coverage is 0.00000%.

❗ Current head c3e0176 differs from pull request most recent head 11aef87. Consider uploading reports for the commit 11aef87 to get more accurate results

Impacted file tree graph

@@                Coverage Diff                 @@
##                main       #132         +/-   ##
==================================================
- Coverage   11.41597%   9.81656%   -1.59941%     
==================================================
  Files             14         14                 
  Lines           2041       2017         -24     
==================================================
- Hits             233        198         -35     
- Misses          1791       1805         +14     
+ Partials          17         14          -3     
Impacted Files Coverage Δ
clients/catalyst.go 88.31169% <ø> (ø)
task/paths.go 0.00000% <0.00000%> (ø)
task/runner.go 17.33967% <0.00000%> (-0.65098%) ⬇️
task/upload.go 0.00000% <0.00000%> (-7.82828%) ⬇️
task/progress.go 0.00000% <0.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af4b3e0...11aef87. Read the comment docs.

Impacted Files Coverage Δ
clients/catalyst.go 88.31169% <ø> (ø)
task/paths.go 0.00000% <0.00000%> (ø)
task/runner.go 17.33967% <0.00000%> (-0.65098%) ⬇️
task/upload.go 0.00000% <0.00000%> (-7.82828%) ⬇️
task/progress.go 0.00000% <0.00000%> (ø)

@gioelecerati gioelecerati changed the title task-runner: add mp4 short form task-runner: add mp4 output in catalyst request & callback Feb 1, 2023
task/paths.go Outdated Show resolved Hide resolved
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the right path

task/upload.go Outdated Show resolved Hide resolved
task/paths.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
@gioelecerati gioelecerati marked this pull request as ready for review February 2, 2023 15:39
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 required changes

task/upload.go Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

clients/catalyst.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

task/paths.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
task/upload.go Show resolved Hide resolved
@gioelecerati gioelecerati merged commit da64ec0 into main Feb 16, 2023
@gioelecerati gioelecerati deleted the gio/feat/short-form branch February 16, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalyst <-> Studio integration for Short form videos
2 participants