Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web3 Storage #134

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Web3 Storage #134

merged 3 commits into from
Feb 7, 2023

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Feb 2, 2023

No description provided.

@leszko leszko requested a review from a team as a code owner February 2, 2023 12:12
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #134 (88a77e2) into main (a0971d9) will decrease coverage by 0.03555%.
The diff coverage is 23.07692%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #134         +/-   ##
===================================================
- Coverage   10.04566%   10.01011%   -0.03555%     
===================================================
  Files             14          14                 
  Lines           1971        1978          +7     
===================================================
  Hits             198         198                 
- Misses          1760        1767          +7     
  Partials          13          13                 
Impacted Files Coverage Δ
task/upload.go 0.00000% <0.00000%> (ø)
clients/catalyst.go 91.89189% <100.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0971d9...88a77e2. Read the comment docs.

Impacted Files Coverage Δ
task/upload.go 0.00000% <0.00000%> (ø)
clients/catalyst.go 91.89189% <100.00000%> (ø)

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A few questions on the overall logic tho.

task/upload.go Show resolved Hide resolved
task/upload.go Show resolved Hide resolved
@leszko leszko merged commit ac3376f into main Feb 7, 2023
@leszko leszko deleted the rafal/web3storage branch February 7, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants