Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Allow decrypting input files with AESCBC #141

Merged
merged 19 commits into from
Feb 16, 2023

Conversation

victorges
Copy link
Member

This adds on top of livepeer/studio#1645 to decrypt input files with
AES-256-CBC if a key was provided.

Notice that this should ideally be done in Catalyst for a real implementation, but made this
quickly in order to create an experiment. The file is decrypted and copied to S3 instead of
sent raw to Catalyst.

The experiment name is vod-encrypted-input and is checked by the API here: https://github.com/livepeer/livepeer-com/blob/579b4835ebfc15ca4700ac30b86a45159a4ddd1f/packages/api/src/controllers/asset.ts#L579

@victorges victorges requested a review from a team as a code owner February 6, 2023 16:28
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #141 (a992d94) into main (da64ec0) will decrease coverage by 0.31372%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #141         +/-   ##
===================================================
- Coverage   11.28876%   10.97504%   -0.31372%     
===================================================
  Files             14          14                 
  Lines           2064        2123         +59     
===================================================
  Hits             233         233                 
- Misses          1814        1873         +59     
  Partials          17          17                 
Impacted Files Coverage Δ
task/import.go 0.00000% <0.00000%> (ø)
task/upload.go 6.72451% <0.00000%> (-0.67406%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da64ec0...a992d94. Read the comment docs.

Impacted Files Coverage Δ
task/import.go 0.00000% <0.00000%> (ø)
task/upload.go 6.72451% <0.00000%> (-0.67406%) ⬇️

@victorges victorges force-pushed the vg/feat/decrypt-files-on-input branch 3 times, most recently from 6615e64 to cfe5bb3 Compare February 7, 2023 17:56
task/upload.go Show resolved Hide resolved
task/encryption/decrypt.go Outdated Show resolved Hide resolved
@victorges victorges force-pushed the vg/feat/decrypt-files-on-input branch from 7cd0cd5 to 7d8547e Compare February 16, 2023 15:54
@victorges victorges force-pushed the vg/feat/decrypt-files-on-input branch from 7d8547e to 89a85af Compare February 16, 2023 16:01
@victorges victorges changed the title task: Allow decrypting input files with AES256CBC task: Allow decrypting input files with AESCBC Feb 16, 2023
Copy link
Member Author

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review LGTM (after the prev fixes lol)

@victorges victorges merged commit 1a1eefe into main Feb 16, 2023
@victorges victorges deleted the vg/feat/decrypt-files-on-input branch February 16, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants