Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Transcode API Task output format #145

Merged
merged 8 commits into from
Feb 10, 2023
Merged

Change Transcode API Task output format #145

merged 8 commits into from
Feb 10, 2023

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Feb 9, 2023

Related discussion in livepeer/catalyst#397

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #145 (7236e4b) into main (26ced45) will increase coverage by 1.34716%.
The diff coverage is 63.26531%.

Impacted file tree graph

@@                Coverage Diff                 @@
##               main        #145         +/-   ##
==================================================
+ Coverage   9.94475%   11.29191%   +1.34716%     
==================================================
  Files            14          14                 
  Lines          1991        2028         +37     
==================================================
+ Hits            198         229         +31     
- Misses         1779        1782          +3     
- Partials         14          17          +3     
Impacted Files Coverage Δ
clients/catalyst.go 88.31169% <ø> (ø)
task/runner.go 17.33967% <0.00000%> (ø)
task/upload.go 7.86802% <65.95745%> (+7.86802%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26ced45...7236e4b. Read the comment docs.

Impacted Files Coverage Δ
clients/catalyst.go 88.31169% <ø> (ø)
task/runner.go 17.33967% <0.00000%> (ø)
task/upload.go 7.86802% <65.95745%> (+7.86802%) ⬆️

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only some suggestions

task/runner.go Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
task/upload.go Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
task/upload_test.go Show resolved Hide resolved
Co-authored-by: Victor Elias <victorgelias@gmail.com>
@leszko leszko merged commit ff83054 into main Feb 10, 2023
@leszko leszko deleted the rafal/trancode-output branch February 10, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants