Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

humanize more catalyst errors #147

Merged
merged 3 commits into from
Feb 12, 2023
Merged

humanize more catalyst errors #147

merged 3 commits into from
Feb 12, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Feb 10, 2023

No description provided.

@mjh1 mjh1 requested a review from a team as a code owner February 10, 2023 14:38
task/runner.go Outdated Show resolved Hide resolved
task/runner.go Show resolved Hide resolved
@mjh1 mjh1 requested a review from victorges February 10, 2023 16:15
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #147 (98e5f2d) into main (ff83054) will increase coverage by 0.17463%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #147         +/-   ##
===================================================
+ Coverage   11.29191%   11.46654%   +0.17463%     
===================================================
  Files             14          14                 
  Lines           2028        2032          +4     
===================================================
+ Hits             229         233          +4     
  Misses          1782        1782                 
  Partials          17          17                 
Impacted Files Coverage Δ
task/runner.go 18.11765% <100.00000%> (+0.77798%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff83054...98e5f2d. Read the comment docs.

Impacted Files Coverage Δ
task/runner.go 18.11765% <100.00000%> (+0.77798%) ⬆️

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomshutt thomshutt merged commit ba43fb9 into main Feb 12, 2023
@thomshutt thomshutt deleted the mh/humanize-errors branch February 12, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants