Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runner: humanize max resolution errors from mediaconvert pipeline #150

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

emranemran
Copy link
Contributor

No description provided.

@emranemran emranemran requested a review from a team as a code owner February 16, 2023 02:41
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #150 (2172abf) into main (af4b3e0) will increase coverage by 0.04338%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #150         +/-   ##
===================================================
+ Coverage   11.41597%   11.45935%   +0.04338%     
===================================================
  Files             14          14                 
  Lines           2041        2042          +1     
===================================================
+ Hits             233         234          +1     
  Misses          1791        1791                 
  Partials          17          17                 
Impacted Files Coverage Δ
task/runner.go 18.18182% <100.00000%> (+0.19117%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af4b3e0...2172abf. Read the comment docs.

Impacted Files Coverage Δ
task/runner.go 18.18182% <100.00000%> (+0.19117%) ⬆️

@thomshutt
Copy link
Contributor

This is a good humanization of the error, but should we be smarter in our code that generates the output profiles? Assuming this big resolution is because we're matching a high-resolution source, we could set maximums there and not match beyond a defined maximum (probably 4K)

@emranemran
Copy link
Contributor Author

This is a good humanization of the error, but should we be smarter in our code that generates the output profiles? Assuming this big resolution is because we're matching a high-resolution source, we could set maximums there and not match beyond a defined maximum (probably 4K)

Yeah we should. Filed livepeer/catalyst-api#468 to follow up. I'll go ahead and merge this so that we categorize these correctly for now until the Livepeer pipeline is fully in effect.

@emranemran emranemran merged commit 03623e8 into main Feb 16, 2023
@emranemran emranemran deleted the emran/humanize-max-res-error branch February 16, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants