Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runner: humanize ffprobe errors #152

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Conversation

emranemran
Copy link
Contributor

A close inspection of ffprobe errors now indicates almost all ffprobe failures are related to invalid input.

A close inspection of ffprobe errors now indicates almost all ffprobe failures are related to invalid input.
@emranemran emranemran requested a review from a team as a code owner February 21, 2023 22:25
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #152 (c6baa62) into main (1a1eefe) will not change coverage.
The diff coverage is 100.00000%.

Impacted file tree graph

@@              Coverage Diff              @@
##                main        #152   +/-   ##
=============================================
  Coverage   11.01695%   11.01695%           
=============================================
  Files             14          14           
  Lines           2124        2124           
=============================================
  Hits             234         234           
  Misses          1873        1873           
  Partials          17          17           
Impacted Files Coverage Δ
task/runner.go 18.18182% <100.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a1eefe...c6baa62. Read the comment docs.

Impacted Files Coverage Δ
task/runner.go 18.18182% <100.00000%> (ø)

@thomshutt thomshutt merged commit fa0bad9 into main Feb 22, 2023
@thomshutt thomshutt deleted the emran/humanize-ffprobe-error-exit-1 branch February 22, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants