Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/import: Make probe non-strict for recordings import #155

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

victorges
Copy link
Member

We've been getting errors turning recordings with no audio into assets. This shouldn't
be really a problem for recordings since all we do is download the muxed mp4s and save
them on the object store. They can have no audio without problems (we only needed to
require audio for the oold joy4 workflow).

@victorges victorges requested a review from a team as a code owner February 24, 2023 18:11
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #155 (cc21120) into main (fa0bad9) will decrease coverage by 0.00519%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #155         +/-   ##
===================================================
- Coverage   11.01695%   11.01176%   -0.00519%     
===================================================
  Files             14          14                 
  Lines           2124        2125          +1     
===================================================
  Hits             234         234                 
- Misses          1873        1874          +1     
  Partials          17          17                 
Impacted Files Coverage Δ
task/import.go 0.00000% <0.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa0bad9...cc21120. Read the comment docs.

Impacted Files Coverage Δ
task/import.go 0.00000% <0.00000%> (ø)

@victorges victorges merged commit 6164223 into main Feb 24, 2023
@victorges victorges deleted the vg/fix/audio-less-recordings branch February 24, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant