Tweak the error matching for probe errors #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous string wasn't matching every case, it was also a specific error message coming from the library we are using so subject to change.
Codecov Report
@@ Coverage Diff @@
## main #162 +/- ##
=============================================
Coverage 10.87460% 10.87460%
=============================================
Files 14 14
Lines 2161 2161
=============================================
Hits 235 235
Misses 1909 1909
Partials 17 17
Continue to review full report at Codecov.
|
emranemran
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous string wasn't matching every case, it was also a specific error message coming from the library we are using so subject to change.